Skip to main content

Linus’ discussion about goto statements

As discussed by Linus Torvalds 6 years ago,


From: Linus Torvalds
Subject: Re: any chance of 2.6.0-test*?
Date: Sun, 12 Jan 2003 12:22:26 -0800 (PST)


On Sun, 12 Jan 2003, Rob Wilkens wrote:
>
> However, I have always been taught, and have always believed that
> “goto”s are inherently evil. They are the creators of spaghetti code


No, you’ve been brainwashed by CS people who thought that Niklaus Wirth
actually knew what he was talking about. He didn’t. He doesn’t have a
frigging clue.


> (you start reading through the code to understand it (months or years
> after its written), and suddenly you jump to somewhere totally
> unrelated, and then jump somewhere else backwards, and it all gets ugly
> quickly). This makes later debugging of code total hell.


Any if-statement is a goto. As are all structured loops.


And sometimes structure is good. When it’s good, you should use it.


And sometimes structure is _bad_, and gets into the way, and using a
“goto” is just much clearer.



For example, it is quite common to have conditionals THAT DO NOT NEST.


In which case you have two possibilities


- use goto, and be happy, since it doesn’t enforce nesting


This makes the code _more_ readable, since the code just does what
the algorithm says it should do.


- duplicate the code, and rewrite it in a nesting form so that you can
use the structured jumps.


This often makes the code much LESS readable, harder to maintain,
and bigger.


The Pascal language is a prime example of the latter problem. Because it
doesn’t have a “break” statement, loops in (traditional) Pascal end up
often looking like total shit, because you have to add totally arbitrary
logic to say “I’m done now”.


Linus


Read the full discussion [here]. PHP 5.3 recently introduced goto statements.

Comments

Popular posts from this blog

Architecture Complexity

Here are the items to consider: Coding to an interface Service Oriented Architecture Automated Testing Domain Driven Design Custom Data Access Layer Layered architecture Complexity is relatively equal the number of lines of code. Note that complexity is not bad. It must be justified.

Moving on

So I bought my self a 2.5″ hard drive enclosure for about 750 bucks. I wish I have my own tools for constructing a device as such. Instead of going for a 2GB USB flash drive, I chose to salvage the 30GB hard drive of an incapacitated laptop. Cool isn’t it? Though relatively slower than a typical USB flash drive, the storage capacity outweighs it. [To God] Thanks for being there always.

Bin to hex converter in 16-bit DOS assembly

Just a quick code like putting your keyboard where your brain is. There should be another way of doing this. I hate this code. start: xor al, al xor bl, bl xor cl, cl mov dl, 4 ; use dl as counter input: mov ah, 00 int 16h cmp ah, 1ch je exit cmp al, '0' jb input cmp al, '1' ja input convert: mov cl, dl dec cl ; dl - 1 sub al, 30h ; get original value shl al, cl ; place in the appropriate bit position or bl, al ; save in bl dec dl ; prepare for the next bit jnz input ; must be 4 bits cmp bl, 9 ja letter jbe number letter: add bl, 37h ; because 'A' - 37h is 0Ah jmp here number: add bl, 30h ; because '0' - 30h is 00h here: call display jmp start display: mov ah, 02h ...